Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused properties #8425

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 8, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.87%. Comparing base (9cd683b) to head (f9b69c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8425      +/-   ##
==========================================
- Coverage   90.87%   90.87%   -0.01%     
==========================================
  Files         347      347              
  Lines       21129    21123       -6     
==========================================
- Hits        19202    19196       -6     
  Misses       1927     1927              
Flag Coverage Δ
gui-tests 76.14% <ø> (+<0.01%) ⬆️
integration-tests 54.25% <ø> (-0.05%) ⬇️
unit-tests 68.94% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide merged commit e546895 into equinor:main Aug 9, 2024
37 checks passed
@oyvindeide oyvindeide deleted the remove_unused branch August 9, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants