Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add splitter to rundialog to facilitate UI adjustments #8449

Merged

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Aug 13, 2024

Resolves #8400

Rundialog realization circles and job info table can now be vertically adjusted using the divider between them.
There will be a visual indicator (mouse hand) that hints that the divider is draggable/adjustable.

Screenshot 2024-08-14 at 16 07 41

Screenshot 2024-08-14 at 16 07 47

Screenshot 2024-08-14 at 16 07 57

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (c27d368) to head (a0074ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8449   +/-   ##
=======================================
  Coverage   90.66%   90.67%           
=======================================
  Files         346      346           
  Lines       21018    21022    +4     
=======================================
+ Hits        19057    19062    +5     
+ Misses       1961     1960    -1     
Flag Coverage Δ
gui-tests 75.94% <100.00%> (+0.03%) ⬆️
integration-tests 54.00% <0.00%> (+0.01%) ⬆️
unit-tests 68.69% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@andreas-el andreas-el self-assigned this Aug 14, 2024
@andreas-el andreas-el force-pushed the increase_default_viewport_run_dialog branch from 0242f29 to b309f8b Compare August 14, 2024 14:07
@andreas-el andreas-el added the release-notes:improvement Automatically categorise as improvement in release notes label Aug 14, 2024
@andreas-el andreas-el force-pushed the increase_default_viewport_run_dialog branch from b309f8b to 53668ef Compare August 14, 2024 14:19
@andreas-el andreas-el changed the title Increase minimum height to avoid cutting realization circles Add splitter to rundialog to faciliate UI adjustments Aug 14, 2024
@andreas-el andreas-el changed the title Add splitter to rundialog to faciliate UI adjustments Add splitter to rundialog to facilitate UI adjustments Aug 14, 2024
@andreas-el andreas-el force-pushed the increase_default_viewport_run_dialog branch from 53668ef to a0074ea Compare August 14, 2024 14:20
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗

@andreas-el andreas-el merged commit fb702fb into equinor:main Aug 14, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable resizing of details window in run dialog
4 participants