Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy parts of grdecl_io to heat-eq for speed #8488

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Aug 16, 2024

Importing ert in forward model increases ES-MDA run from 50s to 2min 30s.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Importing ert increases runtime of ES-MDA from 50s to 2min 30s.
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dafeda dafeda merged commit f09843a into equinor:main Aug 16, 2024
35 checks passed
@dafeda dafeda deleted the heat-equation-speed branch August 16, 2024 07:50
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (1336b7c) to head (3594762).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8488      +/-   ##
==========================================
+ Coverage   90.64%   90.65%   +0.01%     
==========================================
  Files         345      345              
  Lines       20981    20981              
==========================================
+ Hits        19018    19021       +3     
+ Misses       1963     1960       -3     
Flag Coverage Δ
gui-tests 75.92% <ø> (-0.02%) ⬇️
integration-tests 53.94% <ø> (+<0.01%) ⬆️
unit-tests 68.66% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants