Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor model config and convert it to pydantic #8501

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 16, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide self-assigned this Aug 16, 2024
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 16, 2024
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (2d73055) to head (15165f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8501      +/-   ##
==========================================
+ Coverage   90.62%   90.65%   +0.02%     
==========================================
  Files         344      344              
  Lines       20966    20979      +13     
==========================================
+ Hits        19001    19019      +18     
+ Misses       1965     1960       -5     
Flag Coverage Δ
gui-tests 75.95% <90.69%> (+0.02%) ⬆️
integration-tests 53.93% <90.69%> (+0.04%) ⬆️
unit-tests 68.64% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide merged commit 22f5f71 into equinor:main Aug 16, 2024
35 checks passed
@oyvindeide oyvindeide deleted the refactor_model_config branch August 16, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants