Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty field for ensemble smoother and manual #8535

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Aug 21, 2024

Issue
Resolves #8459

Fix the remaining panels utilising the Stringbox validation

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.66%. Comparing base (b1c5062) to head (48944ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8535      +/-   ##
==========================================
- Coverage   90.67%   90.66%   -0.01%     
==========================================
  Files         342      342              
  Lines       20942    20942              
==========================================
- Hits        18989    18987       -2     
- Misses       1953     1955       +2     
Flag Coverage Δ
gui-tests 75.81% <ø> (-0.02%) ⬇️
integration-tests 54.08% <ø> (+<0.01%) ⬆️
unit-tests 68.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andreas-el andreas-el merged commit 2544c6a into equinor:main Aug 21, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to empty the target ensemble field in esmda
3 participants