Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change style for disabled simulation modes #8541

Merged

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Aug 21, 2024

Issue
Resolves #8531

⚠️ I set simulation modes containing the word "experiment" as disabled for this test;

Video shows both light and dark mode effects.

Screen.Recording.2024-08-21.at.14.43.44.mov
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el added the release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI label Aug 21, 2024
@andreas-el andreas-el force-pushed the fix_disabled_combobox_items_visuals branch from eb578fa to aa6fbfc Compare August 21, 2024 12:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (31d3aa2) to head (e5c5200).
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/ert/gui/simulation/combobox_with_description.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8541      +/-   ##
==========================================
- Coverage   90.76%   90.75%   -0.01%     
==========================================
  Files         342      342              
  Lines       20935    20937       +2     
==========================================
+ Hits        19001    19002       +1     
- Misses       1934     1935       +1     
Flag Coverage Δ
gui-tests 75.86% <25.00%> (+0.02%) ⬆️
integration-tests 53.97% <0.00%> (+0.02%) ⬆️
unit-tests 68.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@andreas-el andreas-el force-pushed the fix_disabled_combobox_items_visuals branch from f5df0cf to e5c5200 Compare August 26, 2024 07:07
@andreas-el andreas-el merged commit db9f1cd into equinor:main Aug 26, 2024
35 checks passed
@andreas-el andreas-el deleted the fix_disabled_combobox_items_visuals branch August 26, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiment type dropdown is weird for disabled options in dark mode
3 participants