Fix eclipse version config validation on komodo tests #8557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSava
force-pushed
the
fix_eclipse_version_validation_test
branch
from
8e0bd4a
to
4a02d79
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8557 +/- ##
==========================================
- Coverage 90.68% 90.67% -0.01%
==========================================
Files 342 342
Lines 20933 20933
==========================================
- Hits 18983 18981 -2
- Misses 1950 1952 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andreas-el
reviewed
Aug 23, 2024
| @@ -664,6 +672,7 @@ def test_that_no_error_thrown_when_checking_eclipse_version_and_eclrun_is_not_pr | |||
| _ = ErtConfig.with_plugins().from_file(config_file_name) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(shutil.which("eclrun") is not None, reason="eclrun is available") | |||
There was a problem hiding this comment.
Quick question, this needs to be skipped due to eco config will be present when ecl_run present?
There was a problem hiding this comment.
Yes the assumptions is eclxxx_config will be present if ecrun is there
andreas-el
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When applicable