Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restart weights #8559

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Aug 23, 2024

Will add tests when implementation is approved

Issue
Resolves #8491

Screen.Recording.2024-08-23.at.10.26.13.mov
(dev-ert) ➜  33344772-5472-418d-82f2-68eda6eb39af git:(fix_restart_weights) ✗ cat metadata.json
{"weights": "5, 3, 2"}%
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el added the release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI label Aug 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.78%. Comparing base (31d3aa2) to head (ccea4be).
Report is 1 commits behind head on main.

Files Patch % Lines
...gui/simulation/multiple_data_assimilation_panel.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8559      +/-   ##
==========================================
+ Coverage   90.76%   90.78%   +0.02%     
==========================================
  Files         342      342              
  Lines       20935    20941       +6     
==========================================
+ Hits        19001    19011      +10     
+ Misses       1934     1930       -4     
Flag Coverage Δ
gui-tests 75.85% <96.66%> (+0.01%) ⬆️
integration-tests 53.99% <23.33%> (+0.04%) ⬆️
unit-tests 68.78% <23.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren
Copy link
Contributor

Looks good, but I would like to double check with @dafeda about this change :)

@dafeda
Copy link
Contributor

dafeda commented Aug 26, 2024

Looks good, but I would like to double check with @dafeda about this change :)

This makes good sense to me 👍

Store relative weights in metadata.json file
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andreas-el andreas-el merged commit 6d2094e into equinor:main Sep 2, 2024
35 checks passed
@andreas-el andreas-el deleted the fix_restart_weights branch September 2, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weights can be modified on ES MDA restart
4 participants