-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restart weights #8559
Fix restart weights #8559
Conversation
ea96cd8
to
618c8ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8559 +/- ##
==========================================
+ Coverage 90.76% 90.78% +0.02%
==========================================
Files 342 342
Lines 20935 20941 +6
==========================================
+ Hits 19001 19011 +10
+ Misses 1934 1930 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks good, but I would like to double check with @dafeda about this change :) |
This makes good sense to me 👍 |
Store relative weights in metadata.json file
618c8ff
to
ccea4be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Will add tests when implementation is approved
Issue
Resolves #8491
Screen.Recording.2024-08-23.at.10.26.13.mov
When applicable