Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove children_list that shadows the children #8581

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Aug 28, 2024

Resolves #8578

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el self-assigned this Aug 28, 2024
@andreas-el andreas-el added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Aug 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (86c5235) to head (54defc3).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8581      +/-   ##
==========================================
+ Coverage   90.75%   90.79%   +0.03%     
==========================================
  Files         342      342              
  Lines       20938    20937       -1     
==========================================
+ Hits        19003    19009       +6     
+ Misses       1935     1928       -7     
Flag Coverage Δ
gui-tests 75.85% <25.00%> (-0.03%) ⬇️
integration-tests 53.97% <0.00%> (+0.02%) ⬆️
unit-tests 68.79% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Remove unused RealStatusColorHint
Fix get_successful_realizations
@andreas-el andreas-el enabled auto-merge (rebase) August 29, 2024 19:57
@andreas-el andreas-el merged commit 2448875 into equinor:main Aug 29, 2024
35 checks passed
@andreas-el andreas-el deleted the troubleshoot_ui_model branch August 29, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt model indexing will be invalid if multiple full snapshots are transmitted
3 participants