Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompute scaled_errors after autoscaling #8590

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

yngve-sk
Copy link
Contributor

Bugfix?

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (51f40c7) to head (b17c251).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8590      +/-   ##
==========================================
+ Coverage   90.77%   90.78%   +0.01%     
==========================================
  Files         342      342              
  Lines       20946    20938       -8     
==========================================
- Hits        19013    19008       -5     
+ Misses       1933     1930       -3     
Flag Coverage Δ
gui-tests 75.84% <0.00%> (-0.01%) ⬇️
integration-tests 53.95% <0.00%> (-0.01%) ⬇️
unit-tests 68.79% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the bugfix-autoscale-not-used branch 2 times, most recently from 28f1956 to 4e61678 Compare August 30, 2024 07:06
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you also backport to 10.2?

@yngve-sk yngve-sk merged commit e9c4a92 into equinor:main Sep 2, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants