Fix bug checksum failures #8624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the bug where multiple realizations try to read checksum at the same time, leading it to grind to a halt. The issue was fixed by moving the forward_model_ok_lock up a level, so that only one realization can call `verify_checksum` at a time. This also solved the issue where jobs would be shown as stuck in pending even though all forward model steps had completed. This was probably due to checksums all being checked and verified at the same time, which can be IO intensive.
jonathan-eq
added
the
release-notes:bug-fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## version-10.3 #8624 +/- ##
=============================================
Coverage 90.79% 90.79%
=============================================
Files 342 342
Lines 20945 20945
=============================================
Hits 19017 19017
Misses 1928 1928
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
berland
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug where multiple realizations try to read checksum at the same time, leading it to grind to a halt.
The issue was fixed by moving the forward_model_ok_lock up a level, so that only one realization can call
verify_checksumat a time. This also solved the issue where jobs would be shown as stuck in pending even though all forward model steps had completed. This was probably due to checksums all being checked and verified at the same time, which can be IO intensive.Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When applicable