Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecation warning from pytest-asyncio #8629

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Sep 3, 2024

This deprecation warning pops up from pytest-asyncio==0.24

Issue
Resolves warning from pytest runs:

/tmp/f_scout_ci/actions-runner-06/_temp/test-kenv/root/lib64/python3.8/site-packages/pytest_asyncio/plugin.py:208: PytestDeprecationWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset.
The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous fixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "class", "module", "package", "session"

Approach
Read pytest-dev/pytest-asyncio#924

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This deprecation warning pops up from pytest-asyncio==0.24
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Sep 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (d71be2a) to head (3b8ebf2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8629   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         339      339           
  Lines       20866    20881   +15     
=======================================
+ Hits        18959    18973   +14     
- Misses       1907     1908    +1     
Flag Coverage Δ
gui-tests 75.73% <ø> (-0.03%) ⬇️
integration-tests 53.79% <ø> (+0.04%) ⬆️
unit-tests 68.67% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland enabled auto-merge (rebase) September 3, 2024 13:13
@berland berland self-assigned this Sep 3, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@berland berland merged commit 6cac4c0 into equinor:main Sep 3, 2024
35 checks passed
@berland berland deleted the pytest_asyncio_depr branch September 17, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants