Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the everest egg snapshot #8850

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Oct 2, 2024

Issue
Resolves #8842

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad self-assigned this Oct 2, 2024
@frode-aarstad frode-aarstad added the release-notes:skip If there should be no mention of this in release notes label Oct 2, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (0774438) to head (ee87322).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8850      +/-   ##
==========================================
+ Coverage   91.38%   91.40%   +0.02%     
==========================================
  Files         342      343       +1     
  Lines       21034    21086      +52     
==========================================
+ Hits        19221    19273      +52     
  Misses       1813     1813              
Flag Coverage Δ
cli-tests 39.62% <ø> (-0.02%) ⬇️
gui-tests 73.48% <ø> (-0.11%) ⬇️
performance-tests 50.16% <ø> (-0.04%) ⬇️
unit-tests 79.87% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@frode-aarstad frode-aarstad merged commit 8ff7299 into equinor:main Oct 2, 2024
50 checks passed
@frode-aarstad frode-aarstad deleted the update-egg-snapshot branch October 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix egg snapshot test
3 participants