Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtypes of ConfigWarning not being caught #8851

Closed
wants to merge 1 commit into from

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Oct 2, 2024

This commit fixes the issue where subtypes of ConfigWarning would not be reported in the gui/main.py::_start_inititial_gui_window(...) function.

Approach
⛷️

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This commit fixes the issue where subtypes of `ConfigWarning` would not be reported in the `gui/main.py::_start_inititial_gui_window(...)` function.
@jonathan-eq jonathan-eq added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 2, 2024
@jonathan-eq jonathan-eq self-assigned this Oct 2, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (61c648a) to head (71bb3ce).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8851   +/-   ##
=======================================
  Coverage   91.39%   91.40%           
=======================================
  Files         343      343           
  Lines       21087    21087           
=======================================
+ Hits        19272    19274    +2     
+ Misses       1815     1813    -2     
Flag Coverage Δ
cli-tests 39.62% <ø> (+<0.01%) ⬆️
gui-tests 73.51% <ø> (ø)
performance-tests 50.21% <ø> (+0.04%) ⬆️
unit-tests 79.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren
Copy link
Contributor

superseded by #8857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants