Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reserved ports in test_adaptive_localization #8886

Conversation

eivindjahren
Copy link
Contributor

The default for localhost is 49152-51819

Issue
Resolves #8867
Resolves #8787

Approach
The default port range on localhost is already maximal within https://en.wikipedia.org/wiki/Ephemeral_port

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

The default for localhost is 49152-51819
@eivindjahren eivindjahren enabled auto-merge (rebase) October 4, 2024 10:50
@eivindjahren eivindjahren merged commit 810bda7 into equinor:main Oct 4, 2024
56 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (d1c3a88) to head (762a852).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8886      +/-   ##
==========================================
+ Coverage   91.42%   91.43%   +0.01%     
==========================================
  Files         344      344              
  Lines       21120    21120              
==========================================
+ Hits        19308    19312       +4     
+ Misses       1812     1808       -4     
Flag Coverage Δ
cli-tests 39.57% <ø> (-0.06%) ⬇️
gui-tests 73.53% <ø> (-0.02%) ⬇️
performance-tests 50.14% <ø> (ø)
unit-tests 80.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests/ert/ui_tests/cli/analysis/test_adaptive_localization.py Multiple failing cli tests on macos
3 participants