Add some detached <-> scheduler edge cases #8898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8896
Approach
At first the job exists as a FAILED job in scheduler:
if context is not None and context.has_job_failed(0):
, then on the next line it may still be failed, OR (1) set toJobStatus.WAITING
, or (2) removed fromcontext.scheduler._jobs
, these edge cases are currently not handled, and can occur if we are lucky enough for this change to happen in scheduler between these two lines of code:git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable