Move plottery to tools plot #8900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
move_plottery_to_tools_plot
branch
from
894d09b
to
af8d7b5
Compare
eivindjahren
force-pushed
the
move_plottery_to_tools_plot
branch
from
af8d7b5
to
b983d30
Compare
eivindjahren
added
the
release-notes:refactor
eivindjahren
force-pushed
the
move_plottery_to_tools_plot
branch
from
b983d30
to
ff86cad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8900 +/- ##
==========================================
+ Coverage 91.48% 91.49% +0.01%
==========================================
Files 344 345 +1
Lines 21243 21263 +20
==========================================
+ Hits 19434 19455 +21
+ Misses 1809 1808 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Could you mention the explanation (the text in the PR) also in the commit message? |
As plot_api is used by both ert.gui.plottery and ert.gui.tools.plot, its current location causes circular dependency problems. This PR moves plottery into ert.gui.tools.plot so that the only exposed symbol from ert.gui.tools.plot is PlotTool.
Done |
eivindjahren
force-pushed
the
move_plottery_to_tools_plot
branch
from
ff86cad
to
cce4760
Compare
xjules
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As plot_api is used by both ert.gui.plottery and ert.gui.tools.plot, its current location causes circular dependency problems. This PR moves plottery into ert.gui.tools.plot so that the only exposed symbol from ert.gui.tools.plot is
PlotTool.git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable