Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template_render.py up two levels #8988

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 18, 2024

The subdirectories serve no real purpose. There is not going to be a lot of other forward models in here.

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

The subdirectories serve no real purpose. There is not going
to be a lot of other forward models in here.
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Oct 18, 2024
@berland berland self-assigned this Oct 18, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆙

@berland berland enabled auto-merge (rebase) October 18, 2024 10:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (0ca8b0b) to head (f125862).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8988      +/-   ##
==========================================
- Coverage   91.57%   91.55%   -0.02%     
==========================================
  Files         347      347              
  Lines       21397    21397              
==========================================
- Hits        19594    19590       -4     
- Misses       1803     1807       +4     
Flag Coverage Δ
cli-tests 39.60% <ø> (-0.01%) ⬇️
gui-tests 73.55% <ø> (+<0.01%) ⬆️
performance-tests 50.19% <ø> (-0.03%) ⬇️
unit-tests 80.11% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland merged commit e2ba5be into equinor:main Oct 18, 2024
56 checks passed
@berland berland deleted the mv_template_render branch October 31, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants