Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar legend getting cut when loading bar shows #8989

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Oct 18, 2024

Issue
Resolves #8972

Approach
πŸ–οΈ 🌊 πŸ„

(Screenshot of new behavior in GUI if applicable)
image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This commit fixes the issue where the legend bar is being pushed around when the loading bar changes visiblity.
This commit fixes the issue where the bottom of the progress bar label boxes got covered by the widget below.
@jonathan-eq jonathan-eq added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 18, 2024
@jonathan-eq jonathan-eq self-assigned this Oct 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 91.51%. Comparing base (da9495d) to head (b027076).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8989      +/-   ##
==========================================
- Coverage   91.55%   91.51%   -0.04%     
==========================================
  Files         347      347              
  Lines       21397    21403       +6     
==========================================
- Hits        19589    19588       -1     
- Misses       1808     1815       +7     
Flag Coverage Ξ”
cli-tests 39.56% <0.00%> (-0.05%) ⬇️
gui-tests 73.58% <100.00%> (+<0.01%) ⬆️
performance-tests 50.21% <100.00%> (-0.02%) ⬇️
unit-tests 80.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ–οΈ

@jonathan-eq jonathan-eq merged commit 1315c55 into equinor:main Oct 21, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar legend gets cut when in progress
4 participants