Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readthedocs for everest #9074

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Oct 29, 2024

Issue
Related to #8806

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link
Contributor

@frode-aarstad frode-aarstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has there been a change in the config on the read_the_docs account aswell?

@oyvindeide
Copy link
Collaborator Author

Has there been a change in the config on the read_the_docs account aswell?

Yes, I have updated the account, it but requires that this file is merged before I can check that it works.

@oyvindeide oyvindeide added the release-notes:documentation PR with only changes to documentation label Oct 31, 2024
@oyvindeide oyvindeide enabled auto-merge (rebase) October 31, 2024 08:40
@oyvindeide oyvindeide merged commit 3eb3e3c into equinor:main Oct 31, 2024
56 checks passed
@oyvindeide oyvindeide deleted the read_the_docs branch October 31, 2024 11:02
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (c4e1365) to head (7e700c2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9074      +/-   ##
==========================================
- Coverage   90.72%   90.71%   -0.02%     
==========================================
  Files         350      350              
  Lines       21783    21783              
==========================================
- Hits        19763    19760       -3     
- Misses       2020     2023       +3     
Flag Coverage Δ
cli-tests 39.02% <ø> (+0.01%) ⬆️
gui-tests 71.70% <ø> (+0.02%) ⬆️
performance-tests 49.27% <ø> (+0.02%) ⬆️
unit-tests 79.55% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:documentation PR with only changes to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants