Log wall- and cputime for each finished forward model step #9103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: multi-cpu effects are not accounted for in this pr. |
This is meant for making statistics pr forward model step name. While testing on poly_example and local queue, there is some odd occurences of the logged message that start_time is None, this is not believed to happen often in production.
berland
force-pushed
the
log_step_runtime
branch
from
2d18dcb
to
ec2f5de
Compare
berland
added
the
release-notes:maintenance
berland
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9103 +/- ##
==========================================
- Coverage 90.72% 90.70% -0.02%
==========================================
Files 350 350
Lines 21772 21783 +11
==========================================
+ Hits 19752 19759 +7
- Misses 2020 2024 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves lack of runtime logging pr. step
Approach
:tap fast on keyboard:
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable