Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip logging of short fm steps #9122

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

berland
Copy link
Contributor

@berland berland commented Nov 1, 2024

There are more short forward model time steps than we want the logging system to handle.

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

There are more short forward model time steps than we want the logging
system to handle.
@berland berland self-assigned this Nov 1, 2024
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 1, 2024
@berland berland enabled auto-merge (rebase) November 1, 2024 08:45
@berland berland merged commit 6454d3a into equinor:main Nov 1, 2024
56 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.76%. Comparing base (8c312f2) to head (8bc20ce).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/ensemble_evaluator/_ensemble.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9122      +/-   ##
==========================================
+ Coverage   90.71%   90.76%   +0.05%     
==========================================
  Files         350      350              
  Lines       21787    21788       +1     
==========================================
+ Hits        19763    19775      +12     
+ Misses       2024     2013      -11     
Flag Coverage Δ
cli-tests 39.06% <75.00%> (+0.02%) ⬆️
gui-tests 71.69% <75.00%> (-0.01%) ⬇️
performance-tests 49.27% <50.00%> (+0.02%) ⬆️
unit-tests 79.59% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland deleted the reduce_fmstep_logging branch December 27, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants