Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ropt dependency to 0.9.0 #9138

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Update ropt dependency to 0.9.0 #9138

merged 1 commit into from
Nov 4, 2024

Conversation

verveerpj
Copy link
Contributor

Issue
Updates to ropt==0.9.0.

Approach

  • Fix code due to backwards incompatible changes

  • Update pyproject.toml

  • PR title captures the intent of the changes, and is fitting for release notes.

  • Added appropriate release note label

  • Commit history is consistent and clean, in line with the contribution guidelines.

  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@verveerpj verveerpj added release-notes:dependency Automatically categorise as dependency change in release notes everest labels Nov 4, 2024
@verveerpj verveerpj self-assigned this Nov 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.73%. Comparing base (90d11ec) to head (9db026f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ert/run_models/everest_run_model.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9138      +/-   ##
==========================================
- Coverage   90.76%   90.73%   -0.04%     
==========================================
  Files         351      351              
  Lines       21895    21889       -6     
==========================================
- Hits        19874    19861      -13     
- Misses       2021     2028       +7     
Flag Coverage Δ
cli-tests 39.22% <0.00%> (-0.03%) ⬇️
gui-tests 71.76% <0.00%> (+0.01%) ⬆️
performance-tests 49.42% <0.00%> (+0.05%) ⬆️
unit-tests 79.64% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@verveerpj verveerpj merged commit 8c679c1 into main Nov 4, 2024
57 checks passed
@verveerpj verveerpj deleted the update-ropt-0.9 branch November 4, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
everest release-notes:dependency Automatically categorise as dependency change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants