Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make QueueConfig serializable #9143

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Nov 4, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (8c679c1) to head (1146983).

Files with missing lines Patch % Lines
src/ert/config/queue_config.py 95.00% 1 Missing ⚠️
src/ert/scheduler/__init__.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9143      +/-   ##
==========================================
- Coverage   90.78%   90.74%   -0.05%     
==========================================
  Files         351      351              
  Lines       21889    21901      +12     
==========================================
+ Hits        19871    19873       +2     
- Misses       2018     2028      +10     
Flag Coverage Δ
cli-tests 39.23% <63.33%> (+<0.01%) ⬆️
gui-tests 71.75% <63.33%> (-0.04%) ⬇️
performance-tests 49.38% <63.33%> (-0.03%) ⬇️
unit-tests 79.65% <93.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide changed the title Clean some unused EVEREST functionality Make QueueConfig serializable Nov 5, 2024
@oyvindeide oyvindeide marked this pull request as ready for review November 5, 2024 09:03
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@oyvindeide oyvindeide merged commit 05dfe17 into equinor:main Nov 5, 2024
56 checks passed
@oyvindeide oyvindeide deleted the clean_everest branch November 5, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants