-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make QueueConfig serializable #9143
Conversation
7be3d1b
to
4d804f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9143 +/- ##
==========================================
- Coverage 90.78% 90.74% -0.05%
==========================================
Files 351 351
Lines 21889 21901 +12
==========================================
+ Hits 19871 19873 +2
- Misses 2018 2028 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4e58e6b
to
c93ef72
Compare
It is not really a subclass of bool so pydantic validation fails, but its context is also never used so casting is OK.
c93ef72
to
1146983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🚀
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable