Remove mac-everest test to be able to deploy #9309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
force-pushed
the
rm_mac_runners
branch
from
d901334
to
e6d2bc1
Compare
andreas-el
reviewed
Nov 22, 2024
| matrix: | ||
| test-type: [ 'test', 'integration-test', 'everest-models-test' ] | ||
| python-version: [ '3.8', '3.12' ] | ||
| os: [ 'macos-13', 'macos-14', 'macos-14-large'] |
There was a problem hiding this comment.
Have you considered aligning the Everest matrix with the ert matrix?
os: [ 'macos-13', 'macos-14']
exclude:
- os: 'macos-13'
python-version: '3.12'
I think this will resolve your issue.
There was a problem hiding this comment.
Only trying to deploy, not to fix anything..
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## version-11.1 #9309 +/- ##
================================================
+ Coverage 90.84% 90.86% +0.01%
================================================
Files 352 352
Lines 21961 21961
================================================
+ Hits 19950 19954 +4
+ Misses 2011 2007 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves ability to deploy
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable