Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce enum type PhysicalPropertyModel #1148

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner October 24, 2024 19:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes missing coverage. Please review.

Project coverage is 37.20%. Comparing base (5cc8177) to head (d1396f7).

Files with missing lines Patch % Lines
...ain/java/neqsim/thermo/system/SystemInterface.java 0.00% 5 Missing ⚠️
.../physicalpropertysystem/PhysicalPropertyModel.java 73.33% 2 Missing and 2 partials ⚠️
src/main/java/neqsim/thermo/phase/Phase.java 76.92% 3 Missing ⚠️
...im/physicalproperties/PhysicalPropertyHandler.java 0.00% 1 Missing and 1 partial ⚠️
.../main/java/neqsim/thermo/phase/PhaseInterface.java 0.00% 2 Missing ⚠️
...hasereactorflownode/TwoPhasePackedBedFlowNode.java 0.00% 1 Missing ⚠️
...hasepipeflowsystem/TwoPhasePipeFlowSystemReac.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1148   +/-   ##
=========================================
  Coverage     37.19%   37.20%           
- Complexity     5706     5714    +8     
=========================================
  Files           714      715    +1     
  Lines         70720    70739   +19     
  Branches       8122     8125    +3     
=========================================
+ Hits          26302    26315   +13     
- Misses        42799    42803    +4     
- Partials       1619     1621    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmfstatoil asmfstatoil marked this pull request as draft October 24, 2024 20:58
@asmfstatoil asmfstatoil force-pushed the physicalpropertytypes branch 9 times, most recently from 43437e6 to f826394 Compare October 27, 2024 11:34
Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this look like a good improvement of clarity of code.

@asmfstatoil asmfstatoil changed the title feat: introduce enum type PhysicalPropertyType feat: introduce enum type PhysicalPropertyModel Oct 28, 2024
@asmfstatoil asmfstatoil force-pushed the physicalpropertytypes branch 4 times, most recently from e1fedfc to c85c17a Compare October 28, 2024 10:36
@asmfstatoil asmfstatoil force-pushed the physicalpropertytypes branch from c85c17a to 7834de4 Compare October 28, 2024 10:38
@asmfstatoil
Copy link
Collaborator Author

This seems to work now. The following functions have been renamed to clarify what is happening under the hood. No changes has been made for SystemInterace.

image

image
getPhysicalPropertyType -> getPhysicalPropertyModel

@asmfstatoil asmfstatoil marked this pull request as ready for review October 28, 2024 12:09
@asmfstatoil asmfstatoil merged commit e999736 into equinor:master Oct 28, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the physicalpropertytypes branch October 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants