Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Created physical property enum type to replace string #1149

Merged
merged 7 commits into from
Oct 27, 2024

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner October 25, 2024 07:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 85.88235% with 12 lines in your changes missing coverage. Please review.

Project coverage is 37.19%. Comparing base (e8e19d8) to head (fa03fdf).

Files with missing lines Patch % Lines
...ies/physicalpropertysystem/PhysicalProperties.java 77.27% 4 Missing and 1 partial ⚠️
...eqsim/physicalproperties/PhysicalPropertyType.java 85.71% 1 Missing and 1 partial ⚠️
...calpropertysystem/PhysicalPropertiesInterface.java 0.00% 2 Missing ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 77.77% 2 Missing ⚠️
src/main/java/neqsim/thermo/phase/Phase.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1149      +/-   ##
============================================
+ Coverage     37.17%   37.19%   +0.02%     
- Complexity     5694     5708      +14     
============================================
  Files           713      715       +2     
  Lines         70704    70730      +26     
  Branches       8116     8122       +6     
============================================
+ Hits          26287    26311      +24     
- Misses        42799    42800       +1     
- Partials       1618     1619       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmfstatoil asmfstatoil force-pushed the physicalpropertytype branch 4 times, most recently from 2639ffd to 12d50ed Compare October 26, 2024 08:09
Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest that we use more clear name for the physical properties:

DENSITY ➔ MASS_DENSITY
Reflects that it’s the density related to mass in a fluid context.

VISCOSITY ➔ DYNAMIC_VISCOSITY
Highlights that it’s the fluid’s resistance to flow.

CONDUCTIVITY ➔ THERMAL_CONDUCTIVITY
Clarifies that it’s related to heat transfer rather than electrical conductivity.

THis has been a weakness in the current code also.

@asmfstatoil
Copy link
Collaborator Author

I have renamed, but not updated the tests. Should it still be possible to write initPhysicalProperties("viscosity") with the old short names?

@EvenSol
Copy link
Collaborator

EvenSol commented Oct 27, 2024

I have renamed, but not updated the tests. Should it still be possible to write initPhysicalProperties("viscosity") with the old short names?

Yes - It would be good to keep compatibility with old code, so maybe accept both viscosity and dynamic viscosity

@asmfstatoil asmfstatoil merged commit 793eea2 into equinor:master Oct 27, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the physicalpropertytype branch October 27, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants