Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: remove PhysicalpropertiesInterface. Use only PhysicalProperties #1153

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner October 27, 2024 18:20
@asmfstatoil asmfstatoil marked this pull request as draft October 27, 2024 18:20
@asmfstatoil asmfstatoil force-pushed the c branch 2 times, most recently from a698dd8 to 6223c3b Compare October 27, 2024 21:16
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.18%. Comparing base (0eaec68) to head (95e5cf5).

Files with missing lines Patch % Lines
...ies/physicalpropertysystem/PhysicalProperties.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1153   +/-   ##
=========================================
  Coverage     37.18%   37.18%           
  Complexity     5705     5705           
=========================================
  Files           715      714    -1     
  Lines         70726    70726           
  Branches       8122     8122           
=========================================
  Hits          26301    26301           
  Misses        42806    42806           
  Partials       1619     1619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmfstatoil asmfstatoil changed the title dummy refact: remove PhysicalpropertiesInterface. Use only PhysicalProperties Oct 27, 2024
@asmfstatoil asmfstatoil marked this pull request as ready for review October 27, 2024 21:40
@asmfstatoil asmfstatoil force-pushed the c branch 2 times, most recently from 844658c to 5b1103a Compare October 27, 2024 21:47
@asmfstatoil asmfstatoil merged commit 06386f5 into equinor:master Oct 27, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the c branch October 27, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants