Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase num #1189

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Phase num #1189

merged 4 commits into from
Nov 22, 2024

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 20.34976% with 501 lines in your changes missing coverage. Please review.

Project coverage is 39.59%. Comparing base (da485d0) to head (91c40a2).

Files with missing lines Patch % Lines
...peflowsolver/TwoPhaseFixedStaggeredGridSolver.java 0.00% 217 Missing ⚠️
...hase/interphasepipeflow/InterphaseDropletFlow.java 0.00% 35 Missing ⚠️
...lowsolver/stirredcellsolver/StirredCellSolver.java 0.00% 28 Missing ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 22.22% 28 Missing ⚠️
...ies/solidadsorption/PotentialTheoryAdsorption.java 0.00% 26 Missing ⚠️
...wophase/stirredcell/InterphaseStirredCellFlow.java 27.58% 21 Missing ⚠️
...idboundary/heatmasstransfercalc/FluidBoundary.java 32.14% 19 Missing ⚠️
...ndary/reactivefilmmodel/ReactiveFluidBoundary.java 0.00% 15 Missing ⚠️
...e/interphasepipeflow/InterphaseStratifiedFlow.java 57.14% 14 Missing and 1 partial ⚠️
...riumfluidboundary/NonEquilibriumFluidBoundary.java 22.22% 14 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1189   +/-   ##
=========================================
  Coverage     39.59%   39.59%           
  Complexity     5869     5869           
=========================================
  Files           717      717           
  Lines         69702    69703    +1     
  Branches       8117     8117           
=========================================
+ Hits          27598    27601    +3     
+ Misses        40443    40441    -2     
  Partials       1661     1661           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good update!

@asmfstatoil asmfstatoil merged commit 6564c83 into equinor:master Nov 22, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the phaseNum branch November 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants