Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Rachford rice method #1204

Merged
merged 10 commits into from
Dec 8, 2024
Merged

update Rachford rice method #1204

merged 10 commits into from
Dec 8, 2024

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Dec 8, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 24.73118% with 70 lines in your changes missing coverage. Please review.

Project coverage is 40.84%. Comparing base (656d9d6) to head (beb9894).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...hasepipeflowsolver/OnePhaseFixedStaggeredGrid.java 20.00% 4 Missing ⚠️
...ndary/reactivefilmmodel/ReactiveFluidBoundary.java 0.00% 2 Missing ⚠️
...cs/flownode/multiphasenode/MultiPhaseFlowNode.java 0.00% 2 Missing ⚠️
.../multiphasenode/waxnode/WaxDepositionFlowNode.java 0.00% 2 Missing ⚠️
...twophasenode/twophasepipeflownode/AnnularFlow.java 0.00% 2 Missing ⚠️
...phasenode/twophasepipeflownode/BubbleFlowNode.java 0.00% 2 Missing ⚠️
...hasereactorflownode/TwoPhasePackedBedFlowNode.java 0.00% 2 Missing ⚠️
...hasereactorflownode/TwoPhaseTrayTowerFlowNode.java 0.00% 2 Missing ⚠️
...lowsolver/stirredcellsolver/StirredCellSolver.java 0.00% 2 Missing ⚠️
...peflowsolver/TwoPhaseFixedStaggeredGridSolver.java 0.00% 2 Missing ⚠️
... and 40 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1204      +/-   ##
============================================
- Coverage     40.98%   40.84%   -0.14%     
+ Complexity     5915     5909       -6     
============================================
  Files           717      717              
  Lines         67813    67845      +32     
  Branches       8102     8104       +2     
============================================
- Hits          27791    27712      -79     
- Misses        38357    38468     +111     
  Partials       1665     1665              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol merged commit 0a880ae into master Dec 8, 2024
9 checks passed
@EvenSol EvenSol deleted the model-oil-NGL branch December 8, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants