Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created tests for setMolarComposition #311

Merged
merged 7 commits into from
Feb 15, 2022

Conversation

asmfstatoil
Copy link
Collaborator

@asmfstatoil asmfstatoil commented Feb 10, 2022

Added testcases
Some docfixes
feat: included logged error message in neqsimexceptions
bugfix: fractionOfHeavyEnd not set throws notinitializedexception

@asmfstatoil
Copy link
Collaborator Author

@EvenSol Possibly you want to look at the test cases? I am not familiar with pluscharacterization

@asmfstatoil asmfstatoil requested a review from EvenSol February 10, 2022 11:34
@EvenSol
Copy link
Collaborator

EvenSol commented Feb 11, 2022

Seems good, but I will have closer a look at it this weekend.

@EvenSol EvenSol merged commit 954d7e1 into equinor:master Feb 15, 2022
@asmfstatoil asmfstatoil deleted the test_setmolarcomposition branch February 15, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants