-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add calcidentifier to simulation objects #486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvenSol
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine.
EvenSol
added a commit
that referenced
this pull request
Jul 22, 2022
* refact: clean out empty/unused cdf code (#487) * refact: clean out empty/unused cdf code * refact: auto format and auto fix snyk (#488) * [Snyk] Upgrade org.apache.derby:derby from 10.14.2.0 to 10.16.1.1 (#457) * fix: upgrade org.apache.derby:derby from 10.14.2.0 to 10.16.1.1 Snyk has created this PR to upgrade org.apache.derby:derby from 10.14.2.0 to 10.16.1.1. See this package in Maven Repository: https://mvnrepository.com/artifact/org.apache.derby/derby/ See this project in Snyk: https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr * Update pom.xml Try with intermediate version 1.15.2.0, as 10.16.1.1 is not supported for java 11. Co-authored-by: Åsmund Våge Fannemel <34712686+asmfstatoil@users.noreply.github.com> Co-authored-by: Even Solbraa <41290109+EvenSol@users.noreply.github.com> * feat: add calcidentifier to simulation objects (#486) Add unique id showing which call to solve/run that last ran successfully. Also did some refactoring such as autoformatting, reordering of code and moving some code in the class hierarchy. * refact: autoformat and autofix (#489) * NeqSimMSAccessDatabase The NeqSim parameter database in MS Access format. * format (#491) * format * checkstyle fixes (#492) * Formatter (#493) * formatting * autofix Co-authored-by: Åsmund Våge Fannemel <34712686+asmfstatoil@users.noreply.github.com> Co-authored-by: Snyk bot <snyk-bot@snyk.io>
EvenSol
added a commit
that referenced
this pull request
Jul 22, 2022
* refact: clean out empty/unused cdf code (#487) * refact: clean out empty/unused cdf code * refact: auto format and auto fix snyk (#488) * [Snyk] Upgrade org.apache.derby:derby from 10.14.2.0 to 10.16.1.1 (#457) * fix: upgrade org.apache.derby:derby from 10.14.2.0 to 10.16.1.1 Snyk has created this PR to upgrade org.apache.derby:derby from 10.14.2.0 to 10.16.1.1. See this package in Maven Repository: https://mvnrepository.com/artifact/org.apache.derby/derby/ See this project in Snyk: https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr * Update pom.xml Try with intermediate version 1.15.2.0, as 10.16.1.1 is not supported for java 11. Co-authored-by: Åsmund Våge Fannemel <34712686+asmfstatoil@users.noreply.github.com> Co-authored-by: Even Solbraa <41290109+EvenSol@users.noreply.github.com> * feat: add calcidentifier to simulation objects (#486) Add unique id showing which call to solve/run that last ran successfully. Also did some refactoring such as autoformatting, reordering of code and moving some code in the class hierarchy. * refact: autoformat and autofix (#489) * NeqSimMSAccessDatabase The NeqSim parameter database in MS Access format. * format (#491) * format * checkstyle fixes (#492) * Formatter (#493) * formatting * autofix Co-authored-by: Åsmund Våge Fannemel <34712686+asmfstatoil@users.noreply.github.com> Co-authored-by: Snyk bot <snyk-bot@snyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refact: moved property time up in hierarchy to be part of all simulation objects.