Restrict ISO parsing to be closer to standard #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ISO8601 requires exactly four digits for the year, while the current ISO parser in ecl allowed any number of digits. This commit will restrict the parser on this detail.
berland
force-pushed
the
improve_iso_parsing
branch
from
d6f1583
to
5010078
Compare
|
How do you think this will impact users? Should we add labels for releases-notes to communicate it? |
Not sure, the bug fixed by this is only present on Mac, on which we have no users, only developers (?) It will be mentioned in the release notes for ecl though. |
hnformentin
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISO8601 requires exactly four digits for the year, while the current ISO parser in ecl allowed any number of digits. This commit will restrict the parser on this detail.
Issue
Resolves #877
Approach
Add an extra
sscanfthat must pass before an ISO date is validated.