Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ninja to the build requirements #956

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add ninja to the build requirements #956

merged 1 commit into from
Feb 20, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Feb 20, 2024

Currently ninja is listed as a dependency in requirements.txt and installed in CI, but is not listed in the build dependencies in pyproject.toml.

eivindjahren
eivindjahren approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@larsevj larsevj marked this pull request as ready for review February 20, 2024 13:14
@larsevj larsevj merged commit 8f43e8e into main Feb 20, 2024
35 of 37 checks passed
@larsevj larsevj deleted the add_ninja_to_build_requires branch February 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivindjahren eivindjahren eivindjahren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsevj @eivindjahren