Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken util_func #978

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

eivindjahren
Copy link
Collaborator

@eivindjahren eivindjahren commented May 22, 2024

These functions cannot be called as they are missing the parameter to ResdataPrototype bind=False. We can therefore assume that it is unused.

Calling either of these functions results in the following error

Traceback (most recent call last):
  File "test.py", line 3, in <module>
    strcmp_int("1", "2")
  File .../lib/python3.11/site-packages/cwrap/prototype.py", line 217, in __call__
    if self._bind and not args[0].is_initialized():

The line that errors has been in place for two years. Prior to adding this check, the function worked as expected.

These functions cannot be called as they are missing the parameter
to ResdataPrototype bind=False. We can therefore assume that it
is unused.
@eivindjahren eivindjahren merged commit 43bae3c into equinor:main May 23, 2024
18 checks passed
@eivindjahren eivindjahren deleted the remove_util_func branch May 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants