Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validate_pre_experiment-method to DESIGN_KW forward model #646

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Add validate_pre_experiment-method to DESIGN_KW forward model #646

merged 6 commits into from
Oct 4, 2024

Conversation

jonathan-eq
Copy link
Contributor

Resolves #641

eivindjahren
eivindjahren requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this to be a warning instead of an error for now.

@jonathan-eq
Copy link
Contributor Author

Blocked by equinor/ert#8734

@jonathan-eq
Copy link
Contributor Author

This is blocked until ert 11 is in stable

@eivindjahren
Copy link
Contributor

@jonathan-eq You can still create a beta release for ert and set semeio to depend on ert>=11.0.0-b0.

xjules
xjules reviewed Sep 23, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
xjules
xjules approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @jonathan-eq ! 🚀

@jonathan-eq jonathan-eq enabled auto-merge (rebase) September 25, 2024 09:55
eivindjahren
eivindjahren approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonathan-eq
Copy link
Contributor Author

Blocked by equinor/ert#8868

@jonathan-eq jonathan-eq added blocked enhancement New feature or request labels Oct 4, 2024
@eivindjahren
Copy link
Contributor

This should be ready now

@jonathan-eq jonathan-eq merged commit 12bf08b into equinor:main Oct 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjules xjules xjules approved these changes

@eivindjahren eivindjahren eivindjahren approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate DESIGN_KW configuration at start up instead of when running forward model
3 participants
@jonathan-eq @eivindjahren @xjules