Lint with ruff #654
Merged
Lint with ruff #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
to-ruff
branch
3 times, most recently
from
6f7ebb0
to
4d38837
Compare
alifbe
reviewed
Jan 30, 2024
| @@ -71,7 +70,7 @@ | |||
|
|
|||
|
|
|||
| def read_pdm_csv_files( | |||
| csvfiles: Union[pd.DataFrame, str, List[str], List[pd.DataFrame]] | |||
| csvfiles: Union[pd.DataFrame, str, List[str], List[pd.DataFrame]], | |||
There was a problem hiding this comment.
@mferrera interesting that ruff add comma here. Do you know why?
There was a problem hiding this comment.
If I had to guess, it's just because it's easier to add things afterward... and also to indicate to formatters that this should indeed by a multi-line list and not inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.