Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tmp_path in test_mainfunction #667

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Use tmp_path in test_mainfunction #667

merged 1 commit into from
Feb 22, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Feb 22, 2024

Avoids creating a specific file in the /tmp directory, which would make tests fail if run with different users on same machine.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3df859c) 86.26% compared to head (a2db279) 86.26%.

❗ Current head a2db279 differs from pull request most recent head 52d4e17. Consider uploading reports for the commit 52d4e17 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files          50       50           
  Lines        6990     6990           
=======================================
  Hits         6030     6030           
  Misses        960      960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj requested a review from berland February 22, 2024 12:33
@larsevj larsevj merged commit 80ab7f2 into main Feb 22, 2024
6 checks passed
@larsevj larsevj deleted the use_tmp_path_in_test branch February 22, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants