Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to standard column names in params2csv #670

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

tnatt
Copy link
Contributor

@tnatt tnatt commented Feb 26, 2024

PR to standardize the output csv from params2csv when run on an ensemble. Resolves #668

  • Extract case metadata into standard column names ENSEMBLESET, ENSEMBLE, REAL and ITER (similar as csv_merge).
  • Removed the old Realization and Iter columns.
  • Changed to only dropping constant parameters columns

Note, it was considered keep and deprecate the Realization and Iter columns for a period. Still not sure if this is needed.. Discussed with @alifbe and @rnyb, and we all tend to lean towards dropping these columns.

  • this tool is not expected to be very much in use, it is mainly used as an post-processing step
    • The ERT WORKFLOW functionality is very new (just a couple of months) and has not been added to the Drogon dataset yet. Hence few people have probably picked up this functionality.
  • the change is not breaking any logic, and it should be an easy fix for the users.

Any thought on this @mferrera

Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. I think Alif or Roger should probably stamp an approval over myself.

src/subscript/params2csv/params2csv.py Outdated Show resolved Hide resolved
tests/test_params2csv.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mferrera
Copy link
Collaborator

mferrera commented Mar 1, 2024

Please update the commit message before merging 👍

@tnatt tnatt force-pushed the params2csv_updates branch 2 times, most recently from 9c9c711 to 3fd2480 Compare March 4, 2024 10:04
@tnatt
Copy link
Contributor Author

tnatt commented Mar 4, 2024

As discussed with @alifbe and @rnyb:
I've extended the ERT example with an example showing how to extract parameters for all iterations in one go. In addition I've changed the filename for the ERT workflow file to lower case and added "wf_" as prefix to align with standards in Drogon 👍

@tnatt tnatt merged commit a9303b5 into equinor:main Mar 4, 2024
6 checks passed
@tnatt tnatt deleted the params2csv_updates branch March 4, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize column names in params2csv output
3 participants