Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test for check_swatinit #672

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Update test for check_swatinit #672

merged 1 commit into from
Feb 28, 2024

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Feb 28, 2024

OPM flow has an update in saturation modelling which affect the test for check_swatinit

Solve #669

The PR is doing two things:

  • Update test to reflect the new behavior of OPM flow
  • Skip some of the test when run from GitHub because the change is not yet in official OPM flow

rnyb
rnyb approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alifbe alifbe merged commit 7950987 into main Feb 28, 2024
6 checks passed
@alifbe alifbe deleted the update-test-check-swatinit branch February 28, 2024 15:01
mferrera pushed a commit that referenced this pull request Mar 1, 2024
@alifbe @mferrera
Update test for check_swatinit (#672)
71df2f0
This was referenced Mar 3, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnyb rnyb rnyb approved these changes

@mferrera mferrera Awaiting requested review from mferrera

@berland berland Awaiting requested review from berland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alifbe @rnyb