Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove root option and add dates as include_from file #738

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

tralsos
Copy link
Collaborator

@tralsos tralsos commented Sep 11, 2024

Solves #736 and #728

  • Removing the option to specify root for relative paths
  • Adding option to specify dates in yaml config by including it from a another global config yaml file.

The include_from option is using the FMUYamlSafeLoader in grid3d_maps

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.97%. Comparing base (0bd547c) to head (345a617).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   85.99%   85.97%   -0.03%     
==========================================
  Files          51       51              
  Lines        6854     6837      -17     
==========================================
- Hits         5894     5878      -16     
+ Misses        960      959       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tralsos tralsos requested a review from a team September 11, 2024 12:27
@tralsos tralsos merged commit d07ca3f into equinor:main Sep 13, 2024
6 checks passed
@tralsos tralsos deleted the root_includedates branch September 13, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants