Fix indent issue #754
Merged
Fix indent issue #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 52 52
Lines 7307 7307
=======================================
Hits 6278 6278
Misses 1029 1029 ☔ View full report in Codecov by Sentry. |
mferrera
approved these changes
Oct 15, 2024
alifbe
force-pushed
the
fix-indent-issue
branch
from
4da64f2
to
1245d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a subtle issue when building documentation. It gives error message
Unexpected indentation. From what I can see, it doesn't seems to change the output.https://github.com/equinor/subscript/actions/runs/11283815471/job/31383917419#step:13:228
As an addition, remove the
*since it doesn't seems to be formatted properly in documentation.We could consider using
-Woption to turn warning into error.Also fix the issue due to mypy upgrading to 1.12