Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the ensemble exists for the specified iterations before calculating anything #756

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

oddvarlia
Copy link
Collaborator

Purpose: Add a check that the ensemble on scratch disk has completed with the iterations specified in the config file for this script.
This is a workaround to ensure that the calculations of field parameter statistics are started before the final realizations are created. Using the HOOK_WORKFLOW with POST_SIMULATION will start the workflow after each iteration, not after all iterations are completed. This will trigger unnecessary runs of the calculation of field parameter statistics since the only meaningfull calculation is after the final iteration is completed. By adding this check, it is possible to avoid unnecessary calculations and waste of time. Ideally ERT should have an option for HOOK_WORKFLOW that start a workflow in ERT after all iterations are completed, but that is not available by the time of writing.

@oddvarlia oddvarlia marked this pull request as draft October 18, 2024 13:13
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.80%. Comparing base (71ee493) to head (9748951).

Files with missing lines Patch % Lines
src/subscript/field_statistics/field_statistics.py 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   85.81%   85.80%   -0.01%     
==========================================
  Files          52       52              
  Lines        7318     7342      +24     
==========================================
+ Hits         6280     6300      +20     
- Misses       1038     1042       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddvarlia oddvarlia force-pushed the check_ens_path branch 2 times, most recently from 4994d54 to 9e77ad9 Compare October 22, 2024 09:05
@oddvarlia oddvarlia requested a review from alifbe October 22, 2024 09:55
@oddvarlia oddvarlia marked this pull request as ready for review October 22, 2024 09:55
Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oddvarlia oddvarlia merged commit c6cef12 into equinor:main Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants