Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: camera state when hidden page is rendered #1819

Merged
merged 13 commits into from
Dec 8, 2023
Merged

fix: camera state when hidden page is rendered #1819

merged 13 commits into from
Dec 8, 2023

Conversation

w1nklr
Copy link
Collaborator

@w1nklr w1nklr commented Dec 7, 2023 •
edited
Loading

Fix for #1820

Add formal size state and effect to retrieve size from deck ref for code clarity
Move global bounding box handling to React reducer instead of useEffect.
Move camera computation to useMemo instead of useEffect.
Memoize viewPortMargins and deckGLLayers

Add a new story displaying the subsurface viewer in tabs to reproduce the issue

Note that this is a first step to reduce the number of useEffect in the Map component

@w1nklr
Adding a tab'ed story
b0cff58 
The story has a flag controlling the rendering of hidden tabs.

Add triggerHome control to mapLayer and SubsurfaceViewer stories.

Minor props re-ordering to group camera controls
@w1nklr
Memoize viewPortMargins and deckGLLayers
3dc7223
@w1nklr
Add effect to retrieve size from deck ref
61e6bf1 
React rule is not to read/modify ref during rendering.
It proved true: computations where randomly wrong until the size of the deck was extracted in the effect.
@w1nklr
Move global bounding box handling to React reducer.
16d4a22 
This avoids sequences of useEffect calling setState...
@w1nklr
Move camera computation to useMemo
753c6cb
@w1nklr
Fix lint and prettier
ec157c8
@w1nklr w1nklr changed the title Fix camera state when hidden page is rendered fix: camera state when hidden page is rendered Dec 7, 2023
@hkfb
Copy link
Collaborator

hkfb commented Dec 7, 2023

Note that this is a first step to reduce the number of useEffect in the Map component

This is just refactoring and creating an example to demonstrate the bug?

@w1nklr w1nklr requested review from nilscb and hkfb December 7, 2023 15:03
@w1nklr
Copy link
Collaborator Author

w1nklr commented Dec 7, 2023

Note that this is a first step to reduce the number of useEffect in the Map component

This is just refactoring and creating an example to demonstrate the bug?

Nope, it fixes also the bug (ie. the example was showing the bug before I fixed it in the same PR)

hkfb
hkfb reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@hkfb hkfb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error in the console:
image

hkfb
hkfb reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@hkfb hkfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second tab seems wrongly initialized the first time it's opened:
image
The second time I open it I can see the map.

@w1nklr
Copy link
Collaborator Author

w1nklr commented Dec 7, 2023

Warning message fixed.

@w1nklr
Copy link
Collaborator Author

w1nklr commented Dec 7, 2023

The second tab seems wrongly initialized the first time it's opened: image The second time I open it I can see the map.

:/
How are you doing ?
What is your browser ??

@w1nklr w1nklr merged commit 422325e into equinor:master Dec 8, 2023
8 checks passed
hkfb pushed a commit that referenced this pull request Dec 8, 2023
@semantic-release-bot
chore(release): 0.9.2 [skip ci]
7a0276f 
## [0.9.2](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.9.1...subsurface-viewer@0.9.2) (2023-12-08)

### Bug Fixes

* camera state when hidden page is rendered ([#1819](#1819)) ([422325e](422325e)), closes [#1820](#1820)
@hkfb
Copy link
Collaborator

hkfb commented Dec 8, 2023

🎉 This issue has been resolved in version subsurface-viewer@0.9.2 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Dec 8, 2023
@w1nklr w1nklr deleted the fix_deck branch December 8, 2023 07:22
hkfb pushed a commit that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): wsc-common@0.5.8 [skip ci]
2055f6e 
## [0.5.8](https://github.com/equinor/webviz-subsurface-components/compare/wsc-common@0.5.7...wsc-common@0.5.8) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
hkfb pushed a commit that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): well-completions-plot@1.2.8 [skip ci]
da74de5 
## [1.2.8](https://github.com/equinor/webviz-subsurface-components/compare/well-completions-plot@1.2.7...well-completions-plot@1.2.8) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
hkfb pushed a commit that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): subsurface-viewer@0.20.1 [skip ci]
c69afd1 
## [0.20.1](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.20.0...subsurface-viewer@0.20.1) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
hkfb pushed a commit that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): group-tree-plot@1.1.8 [skip ci]
edfacc2 
## [1.1.8](https://github.com/equinor/webviz-subsurface-components/compare/group-tree-plot@1.1.7...group-tree-plot@1.1.8) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
hkfb pushed a commit that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): well-log-viewer@1.5.1 [skip ci]
13eb48c 
## [1.5.1](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.5.0...well-log-viewer@1.5.1) (2024-03-12)

### Bug Fixes

* bump ajv from 7.2.1 to 8.12.0 in /typescript ([#1947](#1947)) ([af95651](af95651)), closes [#2190](#2190) [#2191](#2191) [#2158](#2158) [#2194](#2194) [#2192](#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [#1840](#1840) [#1901](#1901) [#1922](#1922) [#1862](#1862) [#1861](#1861) [#1815](#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [#1819](#1819) [#1725](#1725) [#1757](#1757) [#2195](#2195) [#1971](#1971) [#2194](#2194) [#2184](#2184) [#2193](#2193) [#2183](#2183) [#2158](#2158) [#2160](#2160) [#1935](#1935) [#2192](#2192) [#1949](#1949) [#2191](#2191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkfb hkfb hkfb approved these changes

@nilscb nilscb nilscb approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@w1nklr @hkfb @nilscb