-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mapLayer web worker crashes if no property data provded. #1900
fix: mapLayer web worker crashes if no property data provded. #1900
Conversation
isMesh: boolean, | ||
frame: Frame, | ||
smoothShading: boolean, | ||
gridLines: boolean, | ||
]; | ||
|
||
async function loadURLData(url: string): Promise<Float32Array | null> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these function be shared and used in every place where data arrays are loaded ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they should be but it's more preferable to refactor in a dedicated PR rather than in this bug fixing one.
## [0.14.2](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.14.1...subsurface-viewer@0.14.2) (2024-01-31) ### Bug Fixes * mapLayer web worker crashes if no property data provded. ([#1900](#1900)) ([8cfa9d8](8cfa9d8))
🎉 This issue has been resolved in version subsurface-viewer@0.14.2 🎉 The release is available on GitHub release |
The crash if fixed.
Some mapLayer code refactored.