Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-1912 Show number of (selected) items in content tables #1920

Merged
merged 3 commits into from
Jun 1, 2023
Merged

FIX-1912 Show number of (selected) items in content tables #1920

merged 3 commits into from
Jun 1, 2023

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented May 30, 2023 •
edited by robertbasti
Loading

Fixes

This pull request fixes #1912

Description

  • Content tables with checkable rows now shows the number of total and selected items.
  • Content tables without checkable rows now shows the total number of items.
  • Created tests to test the details above.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

janburak
janburak approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@janburak janburak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

💯

@eliasbruvik eliasbruvik merged commit e16de7a into equinor:main Jun 1, 2023
@eliasbruvik eliasbruvik deleted the FIX-1912 branch June 1, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janburak janburak janburak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show total and optionally selected number of items in Content Tables
2 participants
@eliasbruvik @janburak