Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieving entities by code (not only by id) #21

Closed
wrygiel opened this issue Feb 8, 2017 · 3 comments
Closed

Retrieving entities by code (not only by id) #21

wrygiel opened this issue Feb 8, 2017 · 3 comments
Assignees

Comments

@wrygiel
Copy link
Contributor

wrygiel commented Feb 8, 2017

One of the recent changes to many specifications was adding the distinction between IDs and codes. One of the consequences of this is that we can no longer access (or search) entities by their codes (natural keys) - currently we can do this only by their IDs (surrogate keys).

Perhaps we should modify the existing get endpoints, so that they may take not only a list of IDs, but also a list of codes? The server would be required to scan both lists, and return matching entries in the response.

I think it might be useful. Please comment. @erasmus-without-paper/all-members

@wrygiel wrygiel changed the title Retrieving entities by code (instead of id) Retrieving entities by code (not only by id) Feb 8, 2017
@wrygiel wrygiel self-assigned this Feb 8, 2017
@wrygiel
Copy link
Contributor Author

wrygiel commented Feb 8, 2017

Example use case:

When a student manually enters the course code on his LA (on the sending HEI system), the page can attempt to request more information on this course (by its code) from the receiving HEI system. Of course, this will work only if the student enters the code without any mistakes (the code is case sensitive), but I would still consider this useful.

@kaiqu
Copy link

kaiqu commented Feb 8, 2017

Perhaps we should modify the existing get endpoints, so that they may take not only a list of IDs, but also a list of codes? The server would be required to scan both lists, and return matching entries in the response.

Fine by me.

wrygiel added a commit to erasmus-without-paper/ewp-specs-api-ounits that referenced this issue Feb 9, 2017
@wrygiel
Copy link
Contributor Author

wrygiel commented Feb 9, 2017

Developers, here you can see an example of how this change will look like (in case Organizational Units API). We will prepare similar changes for Courses API and IIAs API.

wrygiel added a commit to erasmus-without-paper/ewp-specs-api-iias that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-courses that referenced this issue Feb 10, 2017
@wrygiel wrygiel closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants