Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from kickstart (#1) #2

Closed
wants to merge 2 commits into from
Closed

Update from kickstart (#1) #2

wants to merge 2 commits into from

Conversation

eratem
Copy link
Owner

@eratem eratem commented Sep 22, 2023

  • Make init.lua copy-paste friendly

  • docs: Update README.md 📚

  • correct typo

Hey y'all 👋

I think there may have been a typo?

  • Remove timeout

  • Add hint to uncomment line to autodetect plugins

  • Remove fixed line number and describe line

  • setup more language servers i use + allow customizing filetypes

  • Fix bug when server not explicitely defined in configuration but installed

  • Fix typo in init.lua

releated -> related

  • fix(init): turn telescope-fzf-native into a dependecy

  • fix: fix brackets

  • fix: missing comma

  • Update init.lua

added a URL to the lua-guide
may help others who miss the :help lua-guide

  • Fix typo in README.md

  • Use telescope for goto implementation

  • Update init.lua

Fix typo in original.

  • Revert gitsigns keymaps but fix vimdiff and fugitive conflict

Originally, the keymaps for jumping to next and previous git hunks were ]c and [c. This was changed in nvim-lua#323 (83b65a1) because they overwrote the built-in vimdiff keymaps.

However, the more traditional solution is to have ]c and [c extend the built-in keymap. This is what fugitive and gitgutter have been doing for years.

Gitsigns doesn't do this by itself, but it has a recommended keymap configuration on which the present patch is based:

https://github.com/lewis6991/gitsigns.nvim#keymaps

The only thing I've added is to have the keymaps work in visual mode as well, which is the same behavior as the built in vimdiff keymaps.

  • treesitter: ensure 'javascript' installed along with typescript and tsx

This parser is actually needed for some JSX parsing, and since typescript and tsx are already getting installed, it makes sense to also install the javascript parser.

  • Add telescope search resume key binding

  • docs: restructure README

  • docs: remove archive installation


eratem and others added 2 commits September 22, 2023 16:29
* Make init.lua copy-paste friendly

* docs: Update README.md 📚

* correct typo

Hey y'all 👋 

I think there may have been a typo?

* Remove timeout

* Add hint to uncomment line to autodetect plugins

* Remove fixed line number and describe line

* setup more language servers i use + allow customizing filetypes

* Fix bug when server not explicitely defined in configuration but installed

* Fix typo in init.lua

releated -> related

* fix(init): turn telescope-fzf-native into a dependecy

* fix: fix brackets

* fix: missing comma

* Update init.lua

added a URL to the lua-guide
may help others who miss the :help lua-guide

* Fix typo in README.md

* Use telescope for goto implementation

* Update init.lua

Fix typo in original.

Co-authored-by: Luis G Estrades <luisgarciaestrades@gmail.com>

* Revert gitsigns keymaps but fix vimdiff and fugitive conflict

Originally, the keymaps for jumping to next and previous git hunks were
]c and [c. This was changed in nvim-lua#323 (83b65a1) because they overwrote the
built-in vimdiff keymaps.

However, the more traditional solution is to have ]c and [c *extend* the
built-in keymap. This is what fugitive and gitgutter have been doing for
years.

Gitsigns doesn't do this by itself, but it has a recommended keymap
configuration on which the present patch is based:

	https://github.com/lewis6991/gitsigns.nvim#keymaps

The only thing I've added is to have the keymaps work in visual mode as
well, which is the same behavior as the built in vimdiff keymaps.

* treesitter: ensure 'javascript' installed along with typescript and tsx

This parser is actually needed for some *JSX* parsing, and since
typescript and tsx are already getting installed, it makes sense to
also install the javascript parser.

* Add telescope search resume key binding

* docs: restructure README

* docs: remove archive installation

---------

Co-authored-by: Dheepak Krishnamurthy <me@kdheepak.com>
Co-authored-by: Andres Lowrie <andres.lowrie@gmail.com>
Co-authored-by: Chris Patti <feoh@feoh.org>
Co-authored-by: Andrew Stewart <andrewianstewart@gmail.com>
Co-authored-by: Dennis-Rall <56480601+Dennis-Rall@users.noreply.github.com>
Co-authored-by: Numkil <merel.jossart@outlook.com>
Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
Co-authored-by: Peter Benjamin <petermbenjamin@gmail.com>
Co-authored-by: daan <daanrongen@Hotmail.com>
Co-authored-by: Smig <89040888+smiggiddy@users.noreply.github.com>
Co-authored-by: Erik <erik.rivas8@gmail.com>
Co-authored-by: E. Aakash <09e.aakash@gmail.com>
Co-authored-by: Luis G Estrades <luisgarciaestrades@gmail.com>
Co-authored-by: George Angelopoulos <george@usermod.net>
Co-authored-by: Dilshod Temirkhodjaev <tdilshod@gmail.com>
Co-authored-by: Luca Saccarola <github.e41mv@aleeas.com>
@eratem eratem closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant