Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4/n permissions] feat: add native token spend limit plugin #79

Merged
merged 11 commits into from
Jul 16, 2024

Conversation

howydev
Copy link
Collaborator

@howydev howydev commented Jun 19, 2024

Adding a native token spend limit plugin

@howydev howydev force-pushed the howy/add-native-token-spend-plugin branch 2 times, most recently from e466fe7 to 783a58a Compare June 24, 2024 21:31
@howydev howydev requested a review from a team June 24, 2024 21:35
@howydev howydev force-pushed the howy/add-native-token-spend-plugin branch from 783a58a to 7ffbc6a Compare June 27, 2024 16:31
@howydev howydev force-pushed the howy/add-native-token-spend-plugin branch from 7ffbc6a to adb3a0c Compare June 27, 2024 19:43
@howydev howydev force-pushed the howy/add-execUO branch 2 times, most recently from c035a8c to 75b3844 Compare June 28, 2024 20:09
@howydev howydev force-pushed the howy/add-native-token-spend-plugin branch from adb3a0c to 2ed6944 Compare June 28, 2024 20:18
@howydev howydev force-pushed the howy/add-native-token-spend-plugin branch from 49a8805 to d38bec5 Compare July 8, 2024 17:38
Copy link
Contributor

@adamegyed adamegyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Had some comments

src/plugins/BasePlugin.sol Show resolved Hide resolved
src/plugins/NativeTokenLimitPlugin.sol Outdated Show resolved Hide resolved
src/plugins/NativeTokenLimitPlugin.sol Show resolved Hide resolved
src/plugins/NativeTokenLimitPlugin.sol Show resolved Hide resolved
src/plugins/NativeTokenLimitPlugin.sol Show resolved Hide resolved
src/plugins/NativeTokenLimitPlugin.sol Outdated Show resolved Hide resolved
src/plugins/NativeTokenLimitPlugin.sol Outdated Show resolved Hide resolved
Base automatically changed from howy/add-execUO to v0.8-develop July 9, 2024 18:55
@howydev howydev force-pushed the howy/add-native-token-spend-plugin branch from ca96482 to b570ce6 Compare July 10, 2024 21:54
@howydev howydev force-pushed the howy/add-native-token-spend-plugin branch from 05332c9 to cb61b7f Compare July 16, 2024 02:47
@howydev howydev requested a review from adamegyed July 16, 2024 02:55
Copy link
Contributor

@adamegyed adamegyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Co-authored-by: fangting-alchemy <119372438+fangting-alchemy@users.noreply.github.com>
@howydev howydev merged commit 1685e91 into v0.8-develop Jul 16, 2024
3 checks passed
@howydev howydev deleted the howy/add-native-token-spend-plugin branch July 16, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants