fix: encode some character error with encodeURI #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
erda-bot
approved these changes
Aug 5, 2021
|
/cherry-pick release/1.2 |
erda-bot
pushed a commit
to erda-bot/erda-ui
that referenced
this pull request
Aug 5, 2021
* fix: encode some character error * test: add image holder test
daskyrk
added a commit
that referenced
this pull request
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
when encode some character such as emoji, will throw error and cause page crash.
Does this PR introduce a user interface change?
✅ No
ChangeLog
Does this PR need be patched to older version?
✅ Yes(version is required)
release/1.2
Which issue(s) this PR fixes:
Fixes #